Improved the example commands in running-on-k8s document. #25
Conversation
There was a problem hiding this comment.
Looks like a good change to me, thanks @lins05 !
There are several other places in this file where a spark-submit command is split across multiple files without the \ at the end of lines. Would you please add the \ to those also and then we can merge?
Welcome to the Spark on Kubernetes efforts @lins05 !
|
@ash211 Thanks, updated! |
| --conf spark.jars=file:///opt/spark-plugins/app-plugin.jar \ | ||
| --conf spark.kubernetes.driver.docker.image=registry-host:5000/spark-driver-custom:latest \ | ||
| --conf spark.kubernetes.executor.docker.image=registry-host:5000/spark-executor:latest \ | ||
| http://example.com:8080/applications/sparkpluggable/app.jar \ |
|
Looks good -- merging! Thanks again for the contribution @lins05 ! Have you been able to get this code working based on these docs? |
ash211
merged commit 2a093a8
into
apache-spark-on-k8s:k8s-support-alternate-incremental
|
Yep. I have setup a minikube cluster and sucessfully run the spark pi example in cluster mode, and it's very straight forward by following the doc. It did took me some time to build the spark dist files and the docker images though. |
|
Yep they build pretty slowly -- Spark is a rather large project. If you have issues or suggestions, please file issues in this project and provide feedback feedback. Glad you were able to get it working. |
|
@foxish Not yet, but I'd be happy to, so please tell me how to proceed. Also FWIW I've contributed code to both mesos and spark, but neither of them asked me to sign the CLA. |
|
I know that @iyanuobidele signed one, but that was the CCLA IIRC. |
* Improved the example commands in running-on-k8s document. * Fixed more example commands. * Fixed typo.
* Improved the example commands in running-on-k8s document. * Fixed more example commands. * Fixed typo.
* Improved the example commands in running-on-k8s document. * Fixed more example commands. * Fixed typo.
…rk-on-k8s#25) * Improved the example commands in running-on-k8s document. * Fixed more example commands. * Fixed typo.
…rk-on-k8s#25) * Improved the example commands in running-on-k8s document. * Fixed more example commands. * Fixed typo.
What changes were proposed in this pull request?
Improved the example commands in running-on-k8s document so it's easier to copy & paste. Also fixed the name of the example jar.